This site is the archived OWASP Foundation Wiki and is no longer accepting Account Requests.
To view the new OWASP Foundation website, please visit https://owasp.org

Difference between revisions of "Searching for Code in J2EE/Java"

From OWASP
Jump to: navigation, search
 
(78 intermediate revisions by 12 users not shown)
Line 1: Line 1:
== Performing Text Searches ==
+
{{LinkBar
The basis of the code review is to locate and analyse areas of code which may have application security implications.
+
  | useprev=PrevLink | prev=Crawling Code | lblprev=
Assuming the code reviewer has a thorough understanding of the code, what it is intended to do and the context upon which it is to be used, firstly one needs to sweep the code base for areas of interest.
+
  | usemain=MainLink | main=OWASP Code Review Guide Table of Contents | lblmain=Table of Contents
 +
  | usenext=NextLink | next=Searching for Code in Classic ASP | lblnext=
 +
}}
 +
__TOC__
  
This can be done by performing a text search on the code base looking for keywords relating to API's and functions.
+
==Input and Output Streams==
Below is a guide for .NET framework 1.1 & 2.0
+
These are used to read data into one’s application. They may be potential entry points into an application. The entry points may be from an external source and must be investigated. These may also be used in path traversal attacks or DoS attacks.  
  
=== Searching for code in .NET ===
+
Java.io <br>
 +
java.util.zip <br>
 +
java.util.jar <br>
 +
FileInputStream <br>
 +
ObjectInputStream <br>
 +
FilterInputStream <br>
 +
PipedInputStream <br>
 +
SequenceInputStream <br>
 +
StringBufferInputStream <br>
 +
BufferedReader <br>
 +
ByteArrayInputStream <br>
 +
CharArrayReader <br>
 +
File <br>
 +
ObjectInputStream <br>
 +
PipedInputStream <br>
 +
StreamTokenizer <br>
 +
getResourceAsStream <br>
 +
java.io.FileReader <br>
 +
java.io.FileWriter <br>
 +
java.io.RandomAccessFile <br>
 +
java.io.File <br>
 +
java.io.FileOutputStream <br>
 +
mkdir <br>
 +
renameTo <br>
 +
java.io.File.delete  <br>
 +
java.io.File.listFiles  <br>
 +
java.io.File.list  <br>
  
Firstly one needs to be familiar with the tools one can use in order to perform text searching following on from this one need to know what to look for.
+
==Servlets==
+
These API calls may be avenues for parameter, header, URL, and cookie tampering, HTTP Response Splitting and information leakage. They should be examined closely as many of such APIs obtain the parameters directly from HTTP requests.
In this section we will assume you have a copy of Visual Studio (VS) .NET at hand. VS has two types of search "'''Find in Files'''" and a cmd line tool called '''Findstr'''
 
 
 
The test search tools in XP is not great in my experience and if one has to use this make sure SP2 in installed as it works better.
 
To start off one should scan thorough the code looking for common patterns or keywords such as "User", "Password", "Pswd", "Key", "Http", etc...
 
This can be done using the "Find in Files" tool in VS or using findstring as follows:
 
 
[Find In Files HERE]
 
  
'''findstr /s /m /i /d:c:\projects\codebase\sec "http" *.*'''
+
javax.servlet.* <br>
 +
getParameterNames<br>
 +
getParameterValues<br>
 +
getParameter<br>
 +
getParameterMap<br>
 +
getScheme<br>
 +
getProtocol<br>
 +
getContentType<br>
 +
getServerName<br>
 +
getRemoteAddr<br>
 +
getRemoteHost<br>
 +
getRealPath<br>
 +
getLocalName<br>
 +
getAttribute<br>
 +
getAttributeNames<br>
 +
getLocalAddr<br>
 +
getAuthType<br>
 +
getRemoteUser<br>
 +
getCookies<br>
 +
isSecure<br>
 +
HttpServletRequest<br>
 +
getQueryString<br>
 +
getHeaderNames<br>
 +
getHeaders<br>
 +
getPrincipal<br>
 +
getUserPrincipal<br>
 +
isUserInRole<br>
 +
getInputStream<br>
 +
getOutputStream<br>
 +
getWriter<br>
 +
addCookie<br>
 +
addHeader<br>
 +
setHeader<br>
 +
setAttribute<br>
 +
putValue<br>
 +
javax.servlet.http.Cookie<br>
 +
getName<br>
 +
getPath<br>
 +
getDomain<br>
 +
getComment<br>
 +
getMethod<br>
 +
getPath<br>
 +
getReader<br>
 +
getRealPath<br>
 +
getRequestURI<br>
 +
getRequestURL<br>
 +
getServerName<br>
 +
getValue<br>
 +
getValueNames<br>
 +
getRequestedSessionId<br>
  
===Looking for Keywords===
+
==Cross Site Scripting==
 +
javax.servlet.ServletOutputStream.print <br>
 +
javax.servlet.jsp.JspWriter.print <br>
 +
java.io.PrintWriter.print <br>
  
 +
==Response Splitting==
 +
javax.servlet.http.HttpServletResponse.sendRedirect <br>
 +
addHeader, setHeader <br>
  
 +
==Redirection==
 +
sendRedirect <br>
 +
setStatus <br>
 +
addHeader, setHeader <br>
  
====Http Request Strings====
+
==SQL & Database==
request.querystring
+
Searching for Java Database related code this list should help you pinpoint classes/methods which are involved in the persistence layer of the application being reviewed.  
request.form
 
request.cookies
 
request.certificate
 
request.servervariables
 
request.IsSecureConnection
 
request.TotalBytes
 
request.BinaryRead
 
  
 +
jdbc <br>
 +
executeQuery <br>
 +
select <br>
 +
insert <br>
 +
update <br>
 +
delete <br>
 +
execute <br>
 +
executestatement <br>
 +
createStatement <br>
 +
java.sql.ResultSet.getString <br>
 +
java.sql.ResultSet.getObject <br>
 +
java.sql.Statement.executeUpdate <br>
 +
java.sql.Statement.executeQuery <br>
 +
java.sql.Statement.execute <br>
 +
java.sql.Statement.addBatch <br>
 +
java.sql.Connection.prepareStatement <br>
 +
java.sql.Connection.prepareCall <br>
  
 +
==SSL==
 +
Looking for code which utilises SSL as a medium for point to point encryption. The following fragments should indicate where SSL functionality has been developed.
  
====SQL & Database====
+
com.sun.net.ssl <br>
exec sp_executesql
+
SSLContext <br>
execute sp_executesql
+
SSLSocketFactory <br>
select from
+
TrustManagerFactory <br>
Insert
+
HttpsURLConnection <br>
update
+
KeyManagerFactory <br>
delete from where
 
delete
 
exec sp_
 
execute sp_
 
exec xp_
 
execute sp_
 
exec @
 
execute @
 
executestatement
 
executeSQL
 
setfilter
 
executeQuery
 
GetQueryResultInXML
 
adodb
 
sqloledb
 
sql server
 
driver
 
Server.CreateObject
 
.Provider
 
.Open
 
ADODB.recordset
 
New OleDbConnection
 
ExecuteReader
 
DataSource
 
Microsoft.Jet
 
  
==== HTML Tags====
+
==Session Management==
HtmlEncode
+
getSession <br>
URLEncode
+
invalidate <br>
<applet>
+
getId <br>
<body>
 
<embed>
 
<frame>
 
<frameset>
 
<html>
 
<iframe>
 
<img>
 
<style>
 
<layer>
 
<ilayer>
 
<meta>  
 
  <object>  
 
  
====Input Controls====
+
==Legacy Interaction==
system.web.ui.htmlcontrols.htmlinputhidden
+
Here we may be vulnerable to command injection attacks or OS injection attacks. Java linking to the native OS can cause serious issues and potentially give rise to total server compromise.  
system.web.ui.webcontrols.textbox
 
system.web.ui.webcontrols.listbox
 
system.web.ui.webcontrols.checkboxlist
 
system.web.ui.webcontrols.dropdownlist
 
  
+
java.lang.Runtime.exec <br>
 +
java.lang.Runtime.getRuntime <br>
  
====web.config settings====
+
==Logging==
requestEncoding
+
We may come across some information leakage by examining code below contained in one’s application.  
responseEncoding
 
  
====global.asx====
+
java.io.PrintStream.write <br>
 +
log4j <br>
 +
jLo <br>
 +
Lumberjack <br>
 +
MonoLog <br>
 +
qflog <br>
 +
just4log <br>
 +
log4Ant <br>
 +
JDLabAgent <br>
  
====Threads and Concurrancy====
+
==Architectural Analysis==
 +
If we can identify major architectural components within that application (right away) it can help narrow our search, and we can then look for known vulnerabilities in those components and frameworks:
  
====Reflection, Serialization, Clones====
+
<nowiki>### Ajax </nowiki><br>
 +
XMLHTTP <br>
  
====Crypto====
+
<nowiki>### Struts </nowiki><br>
 +
org.apache.struts <br>
  
====Authorization, Assert & Revert====
+
<nowiki>### Spring </nowiki><br>
 +
org.springframework <br>
  
====Authentication====
+
<nowiki>### Java Server Faces (JSF) </nowiki><br>
 +
import javax.faces <br>
 +
 
 +
<nowiki>### Hibernate </nowiki><br>
 +
import org.hibernate <br>
 +
 
 +
<nowiki>### Castor </nowiki><br>
 +
org.exolab.castor <br>
 +
 
 +
<nowiki>### JAXB </nowiki><br>
 +
javax.xml <br>
 +
 
 +
<nowiki>### JMS </nowiki><br>
 +
JMS <br>
 +
 
 +
==Generic Keywords==
 +
Developers say the darnedest things in their source code. Look for the following keywords as pointers to possible software vulnerabilities:
 +
 
 +
Hack <br>
 +
Kludge <br>
 +
Bypass <br>
 +
Steal <br>
 +
Stolen <br>
 +
Divert <br>
 +
Broke <br>
 +
Trick <br>
 +
FIXME <br>
 +
ToDo <br>
 +
Password <br>
 +
Backdoor <br>
 +
 
 +
==WEB 2.0==
 +
'''Ajax and JavaScript'''
 +
 
 +
Look for Ajax usage, and possible JavaScript issues:
 +
 
 +
document.write <br>
 +
eval <br>
 +
document.cookie <br>
 +
window.location <br>
 +
document.URL <br>
 +
 
 +
==Code Execution==
 +
The following may lead to arbitrary java code execution if source of input data is entrusted or not validated.
 +
java.lang.ClassLoader.defineClass  <br>
 +
java.net.URLClassLoader  <br>
 +
java.beans.Instrospector.getBeanInfo  <br>
 +
System.load  <br>
 +
System.loadLibrary  <br>
 +
Runtime.exec  <br>
 +
ProcessBuilder (constructor)  <br>
 +
javax.script.ScriptEngine.eval  <br>
 +
 
 +
==XMLHTTP==
 +
window.createRequest
 +
 
 +
{{LinkBar
 +
  | useprev=PrevLink | prev=Crawling Code | lblprev=
 +
  | usemain=MainLink | main=OWASP Code Review Guide Table of Contents | lblmain=Table of Contents
 +
  | usenext=NextLink | next=Searching for Code in Classic ASP | lblnext=
 +
}}
 +
 
 +
 
 +
 
 +
 
 +
[[Category:OWASP Code Review Project]]

Latest revision as of 22:44, 18 April 2016

«««« Main
(Table of Contents)
»»»»

Input and Output Streams

These are used to read data into one’s application. They may be potential entry points into an application. The entry points may be from an external source and must be investigated. These may also be used in path traversal attacks or DoS attacks.

Java.io
java.util.zip
java.util.jar
FileInputStream
ObjectInputStream
FilterInputStream
PipedInputStream
SequenceInputStream
StringBufferInputStream
BufferedReader
ByteArrayInputStream
CharArrayReader
File
ObjectInputStream
PipedInputStream
StreamTokenizer
getResourceAsStream
java.io.FileReader
java.io.FileWriter
java.io.RandomAccessFile
java.io.File
java.io.FileOutputStream
mkdir
renameTo
java.io.File.delete
java.io.File.listFiles
java.io.File.list

Servlets

These API calls may be avenues for parameter, header, URL, and cookie tampering, HTTP Response Splitting and information leakage. They should be examined closely as many of such APIs obtain the parameters directly from HTTP requests.

javax.servlet.*
getParameterNames
getParameterValues
getParameter
getParameterMap
getScheme
getProtocol
getContentType
getServerName
getRemoteAddr
getRemoteHost
getRealPath
getLocalName
getAttribute
getAttributeNames
getLocalAddr
getAuthType
getRemoteUser
getCookies
isSecure
HttpServletRequest
getQueryString
getHeaderNames
getHeaders
getPrincipal
getUserPrincipal
isUserInRole
getInputStream
getOutputStream
getWriter
addCookie
addHeader
setHeader
setAttribute
putValue
javax.servlet.http.Cookie
getName
getPath
getDomain
getComment
getMethod
getPath
getReader
getRealPath
getRequestURI
getRequestURL
getServerName
getValue
getValueNames
getRequestedSessionId

Cross Site Scripting

javax.servlet.ServletOutputStream.print
javax.servlet.jsp.JspWriter.print
java.io.PrintWriter.print

Response Splitting

javax.servlet.http.HttpServletResponse.sendRedirect
addHeader, setHeader

Redirection

sendRedirect
setStatus
addHeader, setHeader

SQL & Database

Searching for Java Database related code this list should help you pinpoint classes/methods which are involved in the persistence layer of the application being reviewed.

jdbc
executeQuery
select
insert
update
delete
execute
executestatement
createStatement
java.sql.ResultSet.getString
java.sql.ResultSet.getObject
java.sql.Statement.executeUpdate
java.sql.Statement.executeQuery
java.sql.Statement.execute
java.sql.Statement.addBatch
java.sql.Connection.prepareStatement
java.sql.Connection.prepareCall

SSL

Looking for code which utilises SSL as a medium for point to point encryption. The following fragments should indicate where SSL functionality has been developed.

com.sun.net.ssl
SSLContext
SSLSocketFactory
TrustManagerFactory
HttpsURLConnection
KeyManagerFactory

Session Management

getSession
invalidate
getId

Legacy Interaction

Here we may be vulnerable to command injection attacks or OS injection attacks. Java linking to the native OS can cause serious issues and potentially give rise to total server compromise.

java.lang.Runtime.exec
java.lang.Runtime.getRuntime

Logging

We may come across some information leakage by examining code below contained in one’s application.

java.io.PrintStream.write
log4j
jLo
Lumberjack
MonoLog
qflog
just4log
log4Ant
JDLabAgent

Architectural Analysis

If we can identify major architectural components within that application (right away) it can help narrow our search, and we can then look for known vulnerabilities in those components and frameworks:

### Ajax
XMLHTTP

### Struts
org.apache.struts

### Spring
org.springframework

### Java Server Faces (JSF)
import javax.faces

### Hibernate
import org.hibernate

### Castor
org.exolab.castor

### JAXB
javax.xml

### JMS
JMS

Generic Keywords

Developers say the darnedest things in their source code. Look for the following keywords as pointers to possible software vulnerabilities:

Hack
Kludge
Bypass
Steal
Stolen
Divert
Broke
Trick
FIXME
ToDo
Password
Backdoor

WEB 2.0

Ajax and JavaScript

Look for Ajax usage, and possible JavaScript issues:

document.write
eval
document.cookie
window.location
document.URL

Code Execution

The following may lead to arbitrary java code execution if source of input data is entrusted or not validated. java.lang.ClassLoader.defineClass
java.net.URLClassLoader
java.beans.Instrospector.getBeanInfo
System.load
System.loadLibrary
Runtime.exec
ProcessBuilder (constructor)
javax.script.ScriptEngine.eval

XMLHTTP

window.createRequest


«««« Main
(Table of Contents)
»»»»