This site is the archived OWASP Foundation Wiki and is no longer accepting Account Requests.
To view the new OWASP Foundation website, please visit

Dead Code: Expression is Always True

Revision as of 12:28, 30 October 2008 by KirstenS (talk | contribs)

Jump to: navigation, search

This is a Vulnerability. To view all vulnerabilities, please see the Vulnerability Category page.

This article includes content generously donated to OWASP by MicroFocus Logo.png

ASDR Table of Contents

Last revision (mm/dd/yy): 10/30/2008


This expression will always evaluate to true; the program could be rewritten in a simpler form. The nearby code may be present for debugging purposes, or it may not have been maintained along with the rest of the program. The expression may also be indicative of a bug earlier in the method.

Risk Factors



The following method never sets the variable secondCall after initializing it to true. (The variable firstCall is mistakenly used twice.) The result is that the expression firstCall || secondCall will always evaluate to true, so setUpForCall() will always be invoked.

	public void setUpCalls() {
	  boolean firstCall = true;
	  boolean secondCall = true;
	  if (fCall < 0) {
		firstCall = false;
	  if (sCall < 0) {
		firstCall = false;
	  if (firstCall || secondCall) {

Related Attacks

Related Vulnerabilities

Related Controls

Related Technical Impacts