This site is the archived OWASP Foundation Wiki and is no longer accepting Account Requests.
To view the new OWASP Foundation website, please visit

Difference between revisions of "Dead Code: Expression is Always True"

Jump to: navigation, search
Line 1: Line 1:
#REDIRECT [[Failure to follow guideline/specification]]
Line 7: Line 9:
Last revision (mm/dd/yy): '''{{REVISIONMONTH}}/{{REVISIONDAY}}/{{REVISIONYEAR}}'''
Last revision (mm/dd/yy): '''{{REVISIONMONTH}}/{{REVISIONDAY}}/{{REVISIONYEAR}}'''
[[Category:FIXME|This is the text from the old template. This needs to be rewritten using the new template.]]
Line 61: Line 60:
[[Category:FIXME|add links
In addition, one should classify vulnerability based on the following subcategories: Ex:<nowiki>[[Category:Error Handling Vulnerability]]</nowiki>
Availability Vulnerability
Authorization Vulnerability
Authentication Vulnerability
Concurrency Vulnerability
Configuration Vulnerability
Cryptographic Vulnerability
Encoding Vulnerability
Error Handling Vulnerability
Input Validation Vulnerability
Logging and Auditing Vulnerability
Session Management Vulnerability]]
[[Category:OWASP ASDR Project]]
[[Category:Code Quality Vulnerability]]
[[Category:Code Snippet]]

Revision as of 10:10, 14 February 2009


#REDIRECT Failure to follow guideline/specification

ASDR Table of Contents

Last revision (mm/dd/yy): 02/14/2009


This expression will always evaluate to true; the program could be rewritten in a simpler form. The nearby code may be present for debugging purposes, or it may not have been maintained along with the rest of the program. The expression may also be indicative of a bug earlier in the method.

Risk Factors



The following method never sets the variable secondCall after initializing it to true. (The variable firstCall is mistakenly used twice.) The result is that the expression firstCall || secondCall will always evaluate to true, so setUpForCall() will always be invoked.

	public void setUpCalls() {
	  boolean firstCall = true;
	  boolean secondCall = true;
	  if (fCall < 0) {
		firstCall = false;
	  if (sCall < 0) {
		firstCall = false;
	  if (firstCall || secondCall) {

Related Attacks

Related Vulnerabilities

Related Controls

Related Technical Impacts