Difference between revisions of "Security Code Review in the SDLC"

Revision as of 13:22, 9 January 2009

Security code reviews vary widely in their level of formality. Reviews can be as informal as inviting a friend to help look for a hard to find vulnerability, and they can be as formal as a software inspection process with trained teams, assigned roles and responsibilities, and a formal metric and quality tracking program.

In Peer Reviews in Software, Karl Wiegers lists seven review processes from least to most formal:

1. Ad hoc review
2. Passaround
3. Pair programming
4. Walkthrough
5. Team review
6. Inspection

Throughout the SDLC there are points at which an application security consultant should get involved. Performing security activities across the lifecycle has proven to be far more cost-effective than either a “big design up front” security effort or a single pre-production security review. The reason for intervening at regular intervals is that potential issues can be detected early on in the development life cycle where they are less costly to address.

Integration of security code review into the System Development Life Cycle (SDLC) can yield dramatic results to the overall quality of the code developed. Security code review is not a silver bullet, but is part of a healthy application development diet. Consider it as one of the layers in a defense-in-depth approach to application security. Security code review is also a cornerstone of the approach to developing secure software. The idea of integrating a phase into your SLDC may sound daunting, yet another layer of complexity or an additional cost, but in the long term and in today's cyber landscape it is cost effective, reputation building, and in the best interest of any business to do so.

Waterfall SDLC Example

1. Requirements definition
   1. Application Security Requirements
2. Architecture and Design
   1. Application Security Architecture and/or Threat Model
3. Development
   1. Secure Coding Practices
   2. Security Testing
   3. Security Code Review
4. Test
   1. Penetration Testing
5. Deployment
   1. Secure Configuration Management
   2. Secure Deployment
6. Maintenance

Agile Security Methodology Example

1. Planning
   1. Identify Security Stakeholder Stories
   2. Identify Security Controls
   3. Identify Security Test Cases
2. Sprints
   1. Secure Coding
   2. Security Test Cases
   3. Peer Review with Security
3. Deployment
   1. Security Verification (with Penetration Testing and Security Code Review)

Minimal Resource Available Code Review for Web Applications Model

Very often, risk managers are tasked to manually code review large applications with minimal time and resources. This guide will focus on streamlining the manual code review process and outline the bare minimal essentials that are required for review.

Manual Code Review should at LEAST focus on:

1. Authorization
2. Access Control
3. Input Validation
4. Error Handling
5. Session Management
6. Form Keys or Frequent Session Rotation (for CSRF defense)
7. Proper Application Logging