This site is the archived OWASP Foundation Wiki and is no longer accepting Account Requests.
To view the new OWASP Foundation website, please visit https://owasp.org
Difference between revisions of "Code Correctness: Erroneous String Compare"
From OWASP
Weilin Zhong (talk | contribs) |
(Reverting to last version not containing links to www.textriclisitd.com) |
||
| (7 intermediate revisions by 2 users not shown) | |||
| Line 1: | Line 1: | ||
| − | {{ | + | {{template:CandidateForDeletion}} |
| − | |||
| − | + | #REDIRECT [[Failure to follow guideline/specification]] | |
| − | + | ||
| + | |||
| + | Last revision (mm/dd/yy): '''{{REVISIONMONTH}}/{{REVISIONDAY}}/{{REVISIONYEAR}}''' | ||
==Description== | ==Description== | ||
| + | |||
| + | Strings should be compared with the equals() method, not == or !=. | ||
This program uses == or != to compare two strings for equality, which compares two objects for equality, not their values. Chances are good that the two references will never be equal. | This program uses == or != to compare two strings for equality, which compares two objects for equality, not their values. Chances are good that the two references will never be equal. | ||
| + | |||
| + | ==Risk Factors== | ||
| + | TBD | ||
==Examples == | ==Examples == | ||
| Line 21: | Line 27: | ||
</pre> | </pre> | ||
| − | ==Related | + | ==Related [[Attacks]]== |
| + | |||
| + | * [[Attack 1]] | ||
| + | * [[Attack 2]] | ||
| + | |||
| + | |||
| + | ==Related [[Vulnerabilities]]== | ||
| + | |||
| + | * [[Vulnerability 1]] | ||
| + | * [[Vulnerabiltiy 2]] | ||
| − | |||
| − | ==Related | + | ==Related [[Controls]]== |
| − | + | * [[Control 1]] | |
| + | * [[Control 2]] | ||
| − | == | + | ==Related [[Technical Impacts]]== |
| − | [[ | + | * [[Technical Impact 1]] |
| + | * [[Technical Impact 2]] | ||
| − | |||
| − | [[ | + | ==References== |
| + | Note: A reference to related [http://cwe.mitre.org/ CWE] or [http://capec.mitre.org/ CAPEC] article should be added when exists. Eg: | ||
| − | [[ | + | * [http://cwe.mitre.org/data/definitions/79.html CWE 79]. |
| + | * http://www.link1.com | ||
| + | * [http://www.link2.com Title for the link2] | ||
Latest revision as of 18:29, 27 May 2009
#REDIRECT Failure to follow guideline/specification
Last revision (mm/dd/yy): 05/27/2009
Description
Strings should be compared with the equals() method, not == or !=.
This program uses == or != to compare two strings for equality, which compares two objects for equality, not their values. Chances are good that the two references will never be equal.
Risk Factors
TBD
Examples
The following branch will never be taken.
if (args[0] == STRING_CONSTANT) {
logger.info("miracle");
}
Related Attacks
Related Vulnerabilities
Related Controls
Related Technical Impacts
References
Note: A reference to related CWE or CAPEC article should be added when exists. Eg:
