This site is the archived OWASP Foundation Wiki and is no longer accepting Account Requests.
To view the new OWASP Foundation website, please visit https://owasp.org
Difference between revisions of "Dead Code: Expression is Always True"
| Line 2: | Line 2: | ||
{{Template:Fortify}} | {{Template:Fortify}} | ||
| − | [[ | + | __TOC__ |
| + | |||
| + | [[ASDR Table of Contents]] | ||
Last revision (mm/dd/yy): '''{{REVISIONMONTH}}/{{REVISIONDAY}}/{{REVISIONYEAR}}''' | Last revision (mm/dd/yy): '''{{REVISIONMONTH}}/{{REVISIONDAY}}/{{REVISIONYEAR}}''' | ||
| − | |||
| − | [[ | + | [[Category:FIXME|This is the text from the old template. This needs to be rewritten using the new template.]] |
| − | |||
| Line 95: | Line 95: | ||
[[Category:Implementation]] | [[Category:Implementation]] | ||
[[Category:Code Snippet]] | [[Category:Code Snippet]] | ||
| + | [[Category:Vulnerability]] | ||
Revision as of 12:28, 30 October 2008
This is a Vulnerability. To view all vulnerabilities, please see the Vulnerability Category page.
- This article includes content generously donated to OWASP by
Last revision (mm/dd/yy): 10/30/2008
Description
This expression will always evaluate to true; the program could be rewritten in a simpler form. The nearby code may be present for debugging purposes, or it may not have been maintained along with the rest of the program. The expression may also be indicative of a bug earlier in the method.
Risk Factors
TBD
Examples
The following method never sets the variable secondCall after initializing it to true. (The variable firstCall is mistakenly used twice.) The result is that the expression firstCall || secondCall will always evaluate to true, so setUpForCall() will always be invoked.
public void setUpCalls() {
boolean firstCall = true;
boolean secondCall = true;
if (fCall < 0) {
cancelFCall();
firstCall = false;
}
if (sCall < 0) {
cancelSCall();
firstCall = false;
}
if (firstCall || secondCall) {
setUpForCall();
}
}
Related Attacks
Related Vulnerabilities
Related Controls
Related Technical Impacts
References
TBD
