Top 10 2013-A1-Injection - Revision history

Wichers at 18:16, 19 March 2017

2017-03-19T18:16:12Z

Wichers: Fix some links.

2017-03-19T18:14:18Z

Fix some links.

Neil Smithline: Undo revision 154296 by Neil Smithline (talk) broke links

2013-06-23T14:32:37Z

Undo revision 154296 by Neil Smithline (talk) broke links

Neil Smithline at 14:31, 23 June 2013

2013-06-23T14:31:20Z

T.Gigler: added '|year=2013 |language=en, prev={{Top_10:LanguageFile...}}, |next={{Top_10:LanguageFile...}}' at Top/BottomTemplates and '|language=en' where it has been missing

2013-06-14T20:13:07Z

added '|year=2013 |language=en, prev={{Top_10:LanguageFile...}}, |next={{Top_10:LanguageFile...}}' at Top/BottomTemplates and '|language=en' where it has been missing

Neil Smithline at 18:50, 13 June 2013

2013-06-13T18:50:47Z

Neil Smithline at 18:49, 13 June 2013

2013-06-13T18:49:52Z

Neil Smithline at 18:25, 13 June 2013

2013-06-13T18:25:20Z

T.Gigler: brighter background for 'Top_10_2010:ExampleBeginTemplate' => added '|year=2013'; added some '|language=en'

2013-06-09T14:18:09Z

brighter background for 'Top_10_2010:ExampleBeginTemplate' => added '|year=2013'; added some '|language=en'

T.Gigler: added 'Top_10:SummaryTableTemplate' to get this section easier and to get better prepared for internationalisation. + added '|language=en' to get better prepared for internationalisation.

2013-06-09T11:09:03Z

added 'Top_10:SummaryTableTemplate' to get this section easier and to get better prepared for internationalisation. + added '|language=en' to get better prepared for internationalisation.

@@ Line 70: / Line 70: @@
 * [[XXE | OWASP XML eXternal Entity (XXE) Reference Article]]
 * [[ASVS | ASVS: Output Encoding/Escaping Requirements (V6)]]
-* [[Testing_for_SQL_Injection_(OWASP-DV-005) | OWASP Testing Guide: Chapter on SQL Injection Testing]]
+* [[Testing_for_SQL_Injection_(OTG-INPVAL-005) | OWASP Testing Guide: Chapter on SQL Injection Testing]]
 {{Top_10_2010:SubSubsectionExternalReferencesTemplate}}
 * [http://cwe.mitre.org/data/definitions/77.html CWE Entry 77 on Command Injection]

@@ Line 20: / Line 20: @@
 </td>
-      <td colspan=2  {{Template:Top 10 2010:SummaryTableRowStyleTemplate|year=2013}}>[http://www.owasp.org/index.php/Injection_Flaws  Injection flaws] occur when an application sends untrusted data to an interpreter. Injection flaws are very prevalent, particularly in legacy code.  They are often found in SQL, LDAP, Xpath, or NoSQL queries; OS commands; XML parsers, SMTP Headers, program arguments, etc. Injection flaws are easy to discover when examining code, but frequently hard to discover via testing. Scanners and fuzzers can help attackers find injection flaws.
+      <td colspan=2  {{Template:Top 10 2010:SummaryTableRowStyleTemplate|year=2013}}>[[Injection_Flaws | Injection flaws]] occur when an application sends untrusted data to an interpreter. Injection flaws are very prevalent, particularly in legacy code.  They are often found in SQL, LDAP, Xpath, or NoSQL queries; OS commands; XML parsers, SMTP Headers, program arguments, etc. Injection flaws are easy to discover when examining code, but frequently hard to discover via testing. Scanners and fuzzers can help attackers find injection flaws.
 </td>
@@ Line 40: / Line 40: @@
 Preventing injection requires keeping untrusted data separate from commands and queries.
 # The preferred option is to use a safe API which avoids the use of the interpreter entirely or provides a parameterized interface.  Be careful with APIs, such as stored procedures, that are parameterized, but can still introduce injection under the hood.
-# If a parameterized API is not available, you should carefully escape special characters using the specific escape syntax for that interpreter. [https://www.owasp.org/index.php/ESAPI  OWASP’s ESAPI] provides many of these [http://owasp-esapi-java.googlecode.com/svn/trunk_doc/latest/org/owasp/esapi/Encoder.html  escaping routines].
+# If a parameterized API is not available, you should carefully escape special characters using the specific escape syntax for that interpreter. [[ESAPI | OWASP’s ESAPI]] provides many of these [https://static.javadoc.io/org.owasp.esapi/esapi/2.1.0.1/org/owasp/esapi/Encoder.html escaping routines].
-# Positive or “white list” input validation is also recommended, but is not a complete defense as many applications require special characters in their input. If special characters are required, only approaches 1. and 2. above will make their use safe. [https://www.owasp.org/index.php/ESAPI  OWASP’s ESAPI] has an extensible library of [http://owasp-esapi-java.googlecode.com/svn/trunk_doc/latest/org/owasp/esapi/Validator.html  white list input validation routines].
+# Positive or “white list” input validation is also recommended, but is not a complete defense as many applications require special characters in their input. If special characters are required, only approaches 1. and 2. above will make their use safe. [[ESAPI | OWASP’s ESAPI]] has an extensible library of [https://static.javadoc.io/org.owasp.esapi/esapi/2.1.0.1/org/owasp/esapi/Validator.html white list input validation routines].
 {{Top_10_2010:SubsectionAdvancedTemplate|type={{Top_10_2010:StyleTemplate}}|subsection=example|position=left|risk=1|year=2013|language=en}}
@@ Line 65: / Line 65: @@
 {{Top_10_2010:SubsectionAdvancedTemplate|type={{Top_10_2010:StyleTemplate}}|subsection=references|position=right|risk=1|year=2013|language=en}}
 {{Top_10_2010:SubSubsectionOWASPReferencesTemplate}}
-* [https://www.owasp.org/index.php/SQL_Injection_Prevention_Cheat_Sheet OWASP SQL Injection Prevention Cheat Sheet]
+* [[SQL_Injection_Prevention_Cheat_Sheet | OWASP SQL Injection Prevention Cheat Sheet]]
-* [https://www.owasp.org/index.php/Query_Parameterization_Cheat_Sheet OWASP Query Parameterization Cheat Sheet]
+* [[Query_Parameterization_Cheat_Sheet | OWASP Query Parameterization Cheat Sheet]]
-* [https://www.owasp.org/index.php/Command_Injection OWASP Command Injection Article]
+* [[Command_Injection | OWASP Command Injection Article]]
-* [https://www.owasp.org/index.php/XXE OWASP XML eXternal Entity (XXE) Reference Article]
+* [[XXE | OWASP XML eXternal Entity (XXE) Reference Article]]
-* [https://www.owasp.org/index.php/ASVS ASVS: Output Encoding/Escaping Requirements (V6)]
+* [[ASVS | ASVS: Output Encoding/Escaping Requirements (V6)]]
-* [https://www.owasp.org/index.php/Testing_for_SQL_Injection_(OWASP-DV-005) OWASP Testing Guide: Chapter on SQL Injection Testing]
+* [[Testing_for_SQL_Injection_(OWASP-DV-005) | OWASP Testing Guide: Chapter on SQL Injection Testing]]
 {{Top_10_2010:SubSubsectionExternalReferencesTemplate}}
 * [http://cwe.mitre.org/data/definitions/77.html CWE Entry 77 on Command Injection]

@@ Line 40: / Line 40: @@
 Preventing injection requires keeping untrusted data separate from commands and queries.
 # The preferred option is to use a safe API which avoids the use of the interpreter entirely or provides a parameterized interface.  Be careful with APIs, such as stored procedures, that are parameterized, but can still introduce injection under the hood.
-# If a parameterized API is not available, you should carefully escape special characters using the specific escape syntax for that interpreter. [[ESAPI | OWASP’s ESAPI]]] provides many of these [http://owasp-esapi-java.googlecode.com/svn/trunk_doc/latest/org/owasp/esapi/Encoder.html  escaping routines].
+# If a parameterized API is not available, you should carefully escape special characters using the specific escape syntax for that interpreter. [https://www.owasp.org/index.php/ESAPI  OWASP’s ESAPI] provides many of these [http://owasp-esapi-java.googlecode.com/svn/trunk_doc/latest/org/owasp/esapi/Encoder.html  escaping routines].
-# Positive or “white list” input validation is also recommended, but is not a complete defense as many applications require special characters in their input. If special characters are required, only approaches 1. and 2. above will make their use safe. [[ESAPI | OWASP’s ESAPI]]] has an extensible library of [http://owasp-esapi-java.googlecode.com/svn/trunk_doc/latest/org/owasp/esapi/Validator.html  white list input validation routines].
+# Positive or “white list” input validation is also recommended, but is not a complete defense as many applications require special characters in their input. If special characters are required, only approaches 1. and 2. above will make their use safe. [https://www.owasp.org/index.php/ESAPI  OWASP’s ESAPI] has an extensible library of [http://owasp-esapi-java.googlecode.com/svn/trunk_doc/latest/org/owasp/esapi/Validator.html  white list input validation routines].
 {{Top_10_2010:SubsectionAdvancedTemplate|type={{Top_10_2010:StyleTemplate}}|subsection=example|position=left|risk=1|year=2013|language=en}}
@@ Line 65: / Line 65: @@
 {{Top_10_2010:SubsectionAdvancedTemplate|type={{Top_10_2010:StyleTemplate}}|subsection=references|position=right|risk=1|year=2013|language=en}}
 {{Top_10_2010:SubSubsectionOWASPReferencesTemplate}}
-* [[SQL_Injection_Prevention_Cheat_Sheet | OWASP SQL Injection Prevention Cheat Sheet]]]
+* [https://www.owasp.org/index.php/SQL_Injection_Prevention_Cheat_Sheet OWASP SQL Injection Prevention Cheat Sheet]
-* [[Query_Parameterization_Cheat_Sheet | OWASP Query Parameterization Cheat Sheet]]]
+* [https://www.owasp.org/index.php/Query_Parameterization_Cheat_Sheet OWASP Query Parameterization Cheat Sheet]
-* [[Command_Injection | OWASP Command Injection Article]]]
+* [https://www.owasp.org/index.php/Command_Injection OWASP Command Injection Article]
 * [https://www.owasp.org/index.php/XXE OWASP XML eXternal Entity (XXE) Reference Article]
 * [https://www.owasp.org/index.php/ASVS ASVS: Output Encoding/Escaping Requirements (V6)]

@@ Line 40: / Line 40: @@
 Preventing injection requires keeping untrusted data separate from commands and queries.
 # The preferred option is to use a safe API which avoids the use of the interpreter entirely or provides a parameterized interface.  Be careful with APIs, such as stored procedures, that are parameterized, but can still introduce injection under the hood.
-# If a parameterized API is not available, you should carefully escape special characters using the specific escape syntax for that interpreter. [https://www.owasp.org/index.php/ESAPI  OWASP’s ESAPI] provides many of these [http://owasp-esapi-java.googlecode.com/svn/trunk_doc/latest/org/owasp/esapi/Encoder.html  escaping routines].
+# If a parameterized API is not available, you should carefully escape special characters using the specific escape syntax for that interpreter. [[ESAPI | OWASP’s ESAPI]]] provides many of these [http://owasp-esapi-java.googlecode.com/svn/trunk_doc/latest/org/owasp/esapi/Encoder.html  escaping routines].
-# Positive or “white list” input validation is also recommended, but is not a complete defense as many applications require special characters in their input. If special characters are required, only approaches 1. and 2. above will make their use safe. [https://www.owasp.org/index.php/ESAPI  OWASP’s ESAPI] has an extensible library of [http://owasp-esapi-java.googlecode.com/svn/trunk_doc/latest/org/owasp/esapi/Validator.html  white list input validation routines].
+# Positive or “white list” input validation is also recommended, but is not a complete defense as many applications require special characters in their input. If special characters are required, only approaches 1. and 2. above will make their use safe. [[ESAPI | OWASP’s ESAPI]]] has an extensible library of [http://owasp-esapi-java.googlecode.com/svn/trunk_doc/latest/org/owasp/esapi/Validator.html  white list input validation routines].
 {{Top_10_2010:SubsectionAdvancedTemplate|type={{Top_10_2010:StyleTemplate}}|subsection=example|position=left|risk=1|year=2013|language=en}}
@@ Line 65: / Line 65: @@
 {{Top_10_2010:SubsectionAdvancedTemplate|type={{Top_10_2010:StyleTemplate}}|subsection=references|position=right|risk=1|year=2013|language=en}}
 {{Top_10_2010:SubSubsectionOWASPReferencesTemplate}}
-* [https://www.owasp.org/index.php/SQL_Injection_Prevention_Cheat_Sheet OWASP SQL Injection Prevention Cheat Sheet]
+* [[SQL_Injection_Prevention_Cheat_Sheet | OWASP SQL Injection Prevention Cheat Sheet]]]
-* [https://www.owasp.org/index.php/Query_Parameterization_Cheat_Sheet OWASP Query Parameterization Cheat Sheet]
+* [[Query_Parameterization_Cheat_Sheet | OWASP Query Parameterization Cheat Sheet]]]
-* [https://www.owasp.org/index.php/Command_Injection OWASP Command Injection Article]
+* [[Command_Injection | OWASP Command Injection Article]]]
 * [https://www.owasp.org/index.php/XXE OWASP XML eXternal Entity (XXE) Reference Article]
 * [https://www.owasp.org/index.php/ASVS ASVS: Output Encoding/Escaping Requirements (V6)]

@@ Line 1: / Line 1: @@
 {{Top_10_2013:TopTemplate
      |usenext=2013NextLink
-     |next={{Top_10_2010:ByTheNumbers
+     |next=A2-{{Top_10_2010:ByTheNumbers
                |2
                |year=2013
                |language=en}}
      |useprev=2013PrevLink
-     |prev=T10
+     |prev={{Top_10:LanguageFile|text=top10|year=2013|language=en}}
 }}
@@ Line 77: / Line 79: @@
      |type={{Top_10_2010:StyleTemplate}}
      |usenext=2013NextLink
-     |next={{Top_10_2010:ByTheNumbers
+     |next=A2-{{Top_10_2010:ByTheNumbers
                |2
                |year=2013
                |language=en}}
      |useprev=2013PrevLink
-     |prev=T10
+     |prev={{Top_10:LanguageFile|text=top10|year=2013|language=en}}
 }}

@@ Line 13: / Line 13: @@
 {{Top_10_2010:SummaryTableHeaderEndTemplate|year=2013}}
       <td {{Template:Top 10 2010:SummaryTableRowStyleTemplate|year=2013}}>Consider anyone who can send untrusted data to the system, including external users, internal users, and administrators.
 </td>
       <td {{Template:Top 10 2010:SummaryTableRowStyleTemplate|year=2013}}>Attacker sends simple text-based attacks that exploit the syntax of the targeted interpreter. Almost any source of data can be an injection vector, including internal sources.
 </td>
-      <td colspan=2  {{Template:Top 10 2010:SummaryTableRowStyleTemplate|year=2013}}>[http://www.owasp.org/index.php/Injection_Flaws Injection flaws] occur when an application sends untrusted data to an interpreter. Injection flaws are very prevalent, particularly in legacy code.  They are often found in SQL, LDAP, or XPath queries, OS commands, XML parsers, program arguments, etc. Injection flaws are easy to discover when examining code, but more difficult via testing. Scanners and fuzzers can help attackers find them.
+      <td colspan=2  {{Template:Top 10 2010:SummaryTableRowStyleTemplate|year=2013}}>[http://www.owasp.org/index.php/Injection_Flaws  Injection flaws] occur when an application sends untrusted data to an interpreter. Injection flaws are very prevalent, particularly in legacy code.  They are often found in SQL, LDAP, Xpath, or NoSQL queries; OS commands; XML parsers, SMTP Headers, program arguments, etc. Injection flaws are easy to discover when examining code, but frequently hard to discover via testing. Scanners and fuzzers can help attackers find injection flaws.
 </td>
       <td {{Template:Top 10 2010:SummaryTableRowStyleTemplate|year=2013}}>Injection can result in data loss or corruption, lack of accountability, or denial of access. Injection can sometimes lead to complete host takeover.
 </td>
       <td {{Template:Top 10 2010:SummaryTableRowStyleTemplate|year=2013}}>Consider the business value of the affected data and the platform running the interpreter. All data could be stolen, modified, or deleted.  Could your reputation be harmed?
 </td>
 {{Top_10_2010:SummaryTableEndTemplate|year=2013}}
@@ Line 26: / Line 31: @@
 {{Top_10:SubsectionTableBeginTemplate|type=main}} {{Top_10_2010:SubsectionAdvancedTemplate|type={{Top_10_2010:StyleTemplate}}|subsection=vulnerableTo|position=firstLeft|risk=1|year=2013|language=en}}
 The best way to find out if an application is vulnerable to injection is to verify that all use of interpreters clearly separates untrusted data from the command or query. For SQL calls, this means using bind variables in all prepared statements and stored procedures, and avoiding dynamic queries.
 Checking the code is a fast and accurate way to see if the application uses interpreters safely. Code analysis tools can help a security analyst find the use of interpreters and trace the data flow through the application. Penetration testers can validate these issues by crafting exploits that confirm the vulnerability.
-Automated dynamic scanning which exercises the application may provide insight into whether some exploitable injection flaws exist. Scanners cannot always reach interpreters and have difficulty detecting whether an attack was successful. Poor error handling makes injection flaws easier to discover.
 {{Top_10_2010:SubsectionAdvancedTemplate|type={{Top_10_2010:StyleTemplate}}|subsection=howPrevent|position=right|risk=1|year=2013|language=en}}
 Preventing injection requires keeping untrusted data separate from commands and queries.
-# The preferred option is to use a safe API which avoids the use of the interpreter entirely or provides a parameterized interface.  Be careful of APIs, such as stored procedures, that are parameterized, but can still introduce injection under the hood.
+# The preferred option is to use a safe API which avoids the use of the interpreter entirely or provides a parameterized interface.  Be careful with APIs, such as stored procedures, that are parameterized, but can still introduce injection under the hood.
 # If a parameterized API is not available, you should carefully escape special characters using the specific escape syntax for that interpreter. [https://www.owasp.org/index.php/ESAPI OWASP’s ESAPI] provides many of these [http://owasp-esapi-java.googlecode.com/svn/trunk_doc/latest/org/owasp/esapi/Encoder.html escaping routines].
-# Positive or “white list” input validation with appropriate canonicalization is also recommended, but is not a complete defense as many applications require special characters in their input. [https://www.owasp.org/index.php/ESAPI OWASP’s ESAPI] has an extensible library of [http://owasp-esapi-java.googlecode.com/svn/trunk_doc/latest/org/owasp/esapi/Validator.html |white list input validation routines].
+# If a parameterized API is not available, you should carefully escape special characters using the specific escape syntax for that interpreter. [https://www.owasp.org/index.php/ESAPI  OWASP’s ESAPI] provides many of these [http://owasp-esapi-java.googlecode.com/svn/trunk_doc/latest/org/owasp/esapi/Encoder.html  escaping routines].
 {{Top_10_2010:SubsectionAdvancedTemplate|type={{Top_10_2010:StyleTemplate}}|subsection=example|position=left|risk=1|year=2013|language=en}}
-The application uses untrusted data in the construction of the following vulnerable SQL call:
+'''Scenario #1:''' The application uses untrusted data in the construction of the following '''vulnerable''' SQL call:
 {{Top_10_2010:ExampleBeginTemplate|year=2013}}<span style="color:red;">
-String query = "SELECT * FROM accounts WHERE custID='" + request.getParameter("id") +"'";
+Query HQLQuery = session.createQuery(“FROM accounts
 </span>{{Top_10_2010:ExampleEndTemplate}}
-The attacker modifies the ‘id’ parameter in their browser to send: ' or '1'='1. This changes the meaning of the query to return all the records from the accounts database, instead of only the intended customer’s.
+In both cases, the attacker modifies the ‘id’ parameter value in her browser to send:  <span style="color:red;">' or '1'='1</span>. For example:
 {{Top_10_2010:ExampleBeginTemplate|year=2013}}<span style="color:red;"><nowiki>
 http://example.com/app/accountView?id=' or '1'='1
 </nowiki></span>{{Top_10_2010:ExampleEndTemplate}}
-In the worst case, the attacker uses this weakness to invoke special stored procedures in the database that enable a complete takeover of the database and possibly even the server hosting the database.
+This changes the meaning of both queries to return all the records from the accounts table.  More dangerous attacks could modify data or even invoke stored procedures.
 {{Top_10_2010:SubsectionAdvancedTemplate|type={{Top_10_2010:StyleTemplate}}|subsection=references|position=right|risk=1|year=2013|language=en}}
 {{Top_10_2010:SubSubsectionOWASPReferencesTemplate}}