Top 10 2010-A1-Injection - Revision history

Jacob Robertson at 13:19, 14 June 2011

2011-06-14T13:19:09Z

Jacob Robertson at 13:17, 14 June 2011

2011-06-14T13:17:46Z

Neil Smithline at 04:27, 2 May 2010

2010-05-02T04:27:03Z

Neil Smithline at 04:03, 1 May 2010

2010-05-01T04:03:14Z

Neil Smithline at 00:23, 29 April 2010

2010-04-29T00:23:53Z

Wichers at 15:44, 23 April 2010

2010-04-23T15:44:07Z

Wichers at 15:42, 23 April 2010

2010-04-23T15:42:30Z

Neil Smithline at 06:11, 23 April 2010

2010-04-23T06:11:34Z

Neil Smithline at 05:56, 23 April 2010

2010-04-23T05:56:04Z

Wichers at 17:37, 22 April 2010

2010-04-22T17:37:39Z

@@ Line 30: / Line 30: @@
 {{Top_10_2010:ExampleBeginTemplate}}<span style="color:red;">String query = "SELECT * FROM accounts WHERE custID='" + request.getParameter("id") +"'";</span>{{Top_10_2010:ExampleEndTemplate}}
 The attacker modifies the 'id' parameter in their browser to send: ' or '1'='1. This changes the meaning of the query to return all the records from the accounts database, instead of only the intended customer's.
-{{Top_10_2010:ExampleBeginTemplate}}<nowiki>http://example.com/app/accountView?id='</nowiki> or <span style="color: red;">'1'='1</span>{{Top_10_2010:ExampleEndTemplate}}
+{{Top_10_2010:ExampleBeginTemplate}}<nowiki>http://example.com/app/accountView?id=</nowiki><span style="color: red;">' or '1'='1</span>{{Top_10_2010:ExampleEndTemplate}}
 In the worst case, the attacker uses this weakness to invoke special stored procedures in the database, allowing a complete takeover of the database host.
 {{Top_10_2010:SubsectionAdvancedTemplate|type={{Top_10_2010:StyleTemplate}}|number=4|risk=1}}

@@ Line 30: / Line 30: @@
 {{Top_10_2010:ExampleBeginTemplate}}<span style="color:red;">String query = "SELECT * FROM accounts WHERE custID='" + request.getParameter("id") +"'";</span>{{Top_10_2010:ExampleEndTemplate}}
 The attacker modifies the 'id' parameter in their browser to send: ' or '1'='1. This changes the meaning of the query to return all the records from the accounts database, instead of only the intended customer's.
-{{Top_10_2010:ExampleBeginTemplate}}<nowiki>http://example.com/app/accountView?id='</nowiki> or <span style="color: red;">1'='1</span>{{Top_10_2010:ExampleEndTemplate}}
+{{Top_10_2010:ExampleBeginTemplate}}<nowiki>http://example.com/app/accountView?id='</nowiki> or <span style="color: red;">'1'='1</span>{{Top_10_2010:ExampleEndTemplate}}
 In the worst case, the attacker uses this weakness to invoke special stored procedures in the database, allowing a complete takeover of the database host.
 {{Top_10_2010:SubsectionAdvancedTemplate|type={{Top_10_2010:StyleTemplate}}|number=4|risk=1}}

@@ Line 28: / Line 28: @@
 {{Top_10_2010:SubsectionAdvancedTemplate|type={{Top_10_2010:StyleTemplate}}|number=3|risk=1}}
 The application uses untrusted data in the construction of the following vulnerable SQL call:
-:<b><span style="color:red;">String query = "SELECT * FROM accounts WHERE custID='" + request.getParameter("id") +"'";</span></b>
+{{Top_10_2010:ExampleBeginTemplate}}<span style="color:red;">String query = "SELECT * FROM accounts WHERE custID='" + request.getParameter("id") +"'";</span>{{Top_10_2010:ExampleEndTemplate}}
 The attacker modifies the 'id' parameter in their browser to send: ' or '1'='1. This changes the meaning of the query to return all the records from the accounts database, instead of only the intended customer's.
-:<b><nowiki>http://example.com/app/accountView?id='</nowiki> or <span style="color: red;">1'='1</span></b>
+{{Top_10_2010:ExampleBeginTemplate}}<nowiki>http://example.com/app/accountView?id='</nowiki> or <span style="color: red;">1'='1</span>{{Top_10_2010:ExampleEndTemplate}}
 In the worst case, the attacker uses this weakness to invoke special stored procedures in the database, allowing a complete takeover of the database host.
 {{Top_10_2010:SubsectionAdvancedTemplate|type={{Top_10_2010:StyleTemplate}}|number=4|risk=1}}

@@ Line 1: / Line 1: @@
 {{Top_10_2010:TopTemplate|usenext=2010NextLink|next=A2-Cross-Site Scripting (XSS)|useprev=2010PrevLink|prev=Main}}
-<center>
-{| style="align:center; text-align:center; border:2px solid #4F81BD; background-color:#F2F2F2; padding=2;"
+{{Top_10_2010:SummaryTableHeaderBeginTemplate}}
-|- style="background-color: #4F81Bd; color: #FFFFFF;"
+{{Top_10_2010:SummaryTableValue-1-Template|Exploitability|EASY}}
-! width="16.5%" | Threat Agents
+{{Top_10_2010:SummaryTableValue-2-Template|Prevalence|COMMON}}
-! width="16.5%" | Attack Vectors
+{{Top_10_2010:SummaryTableValue-2-Template|Detectability|AVERAGE}}
-! width="33%" colspan="2" | Security Weakness
+{{Top_10_2010:SummaryTableValue-1-Template|Impact|SEVERE}}
-! width="16.5%" | Technical Impacts
+{{Top_10_2010:SummaryTableHeaderEndTemplate}}
-! width="16.5%" | Business Impacts
+     <td {{Template:Top 10 2010:SummaryTableRowStyleTemplate}}>Consider anyone who can send untrusted data to the system, including external users, internal users, and administrators.</td>
-|-
+     <td {{Template:Top 10 2010:SummaryTableRowStyleTemplate}}>Attacker sends simple text-based attacks that exploit the syntax of the targeted interpreter. Almost any source of data can be an injection vector, including internal sources</td>
-| style="background-color: #D9D9D9; color: #000000;" | ______
+     <td colspan=2  {{Template:Top 10 2010:SummaryTableRowStyleTemplate}}>Injection flaws occur when an application sends untrusted data to an interpreter. Injection flaws are very prevalent, particularly in legacy code, often found in SQL queries, LDAP queries, XPath queries, OS commands, program arguments, etc. Injection flaws are easy to discover when examining code, but more difficult via testing. Scanners and fuzzers can help attackers find them.</td>
-| style="background-color: #FF0000; color: #000000;" | '''Exploitability<br>EASY'''
+     <td {{Template:Top 10 2010:SummaryTableRowStyleTemplate}}>Injection can result in data loss or corruption, lack of accountability, or denial of access. Injection can sometimes lead to complete host takeover.</td>
-| style="background-color: #FFB200; color: #000000;" | '''Prevalence<br>COMMON'''
+     <td {{Template:Top 10 2010:SummaryTableRowStyleTemplate}}>Consider the business value of the affected data and the platform running the interpreter. All data could be stolen, modified, or deleted. Could your reputation be harmed?</td>
-| style="background-color: #FFB200; color: #000000;" | '''Detectability<br>AVERAGE'''
+{{Top_10_2010:SummaryTableEndTemplate}}
 {{Top_10_2010:SubsectionAdvancedTemplate|type={{Top_10_2010:StyleTemplate}}|number=1|risk=1}}

@@ Line 24: / Line 24: @@
 </center>
-{{Top_10_2010:SubsectionVulnerableTemplate|Injection|
+{{Top_10_2010:SubsectionAdvancedTemplate|type={{Top_10_2010:StyleTemplate}}|number=1|risk=1}}
 The best way to find out if an application is vulnerable to injection is to verify that all use of interpreters clearly separates untrusted data from the command or query. For SQL calls, this means using bind variables in all prepared statements and stored procedures, and avoiding dynamic queries.
@@ Line 30: / Line 30: @@
 Automated dynamic scanning which exercises the application may provide insight into whether some exploitable injection problems exist. Scanners cannot always reach interpreters and can have difficulty detecting whether an attack was successful.
-}}
+{{Top_10_2010:SubsectionAdvancedTemplate|type={{Top_10_2010:StyleTemplate}}|number=2|risk=1}}
 Preventing injection requires keeping untrusted data separate from commands and queries.
@@ Line 37: / Line 36: @@
 #If a parameterized API is not available, you should carefully escape special characters using the specific escape syntax for that interpreter. [[ESAPI | OWASP's ESAPI]] has some of these [http://owasp-esapi-java.googlecode.com/svn/trunk_doc/latest/org/owasp/esapi/Encoder.html escaping routines].
 #Positive or "whitelist" input validation with appropriate canonicalization also helps protect against injection, but is '''not''' a complete defense as many applications require special characters in their input. [[ESAPI | OWASP's ESAPI]] has an extensible library of [http://owasp-esapi-java.googlecode.com/svn/trunk_doc/latest/org/owasp/esapi/Validator.html white list input validation routines].
-}}
+{{Top_10_2010:SubsectionAdvancedTemplate|type={{Top_10_2010:StyleTemplate}}|number=3|risk=1}}
 The application uses untrusted data in the construction of the following vulnerable SQL call:
 :<b><span style="color:red;">String query = "SELECT * FROM accounts WHERE custID='" + request.getParameter("id") +"'";</span></b>
@@ Line 44: / Line 42: @@
 :<b><nowiki>http://example.com/app/accountView?id='</nowiki> or <span style="color: red;">1'='1</span></b>
 In the worst case, the attacker uses this weakness to invoke special stored procedures in the database, allowing a complete takeover of the database host.
+{{Top_10_2010:SubsectionAdvancedTemplate|type={{Top_10_2010:StyleTemplate}}|number=4|risk=1}}
 {{Top_10_2010:SubSubsectionOWASPReferencesTemplate}}
 * [[SQL_Injection_Prevention_Cheat_Sheet | OWASP SQL Injection Prevention Cheat Sheet]]
@@ Line 58: / Line 55: @@
 * [http://cwe.mitre.org/data/definitions/77.html CWE Entry 77 on Command Injection]
 * [http://cwe.mitre.org/data/definitions/89.html CWE Entry 89 on SQL Injection]
-{{Top_10_2010:BottomTemplate|usenext=2010NextLink|next=A2-Cross-Site Scripting (XSS)|useprev=2010PrevLink|prev=Main}}
+{{Top_10_2010:BottomAdvancedTemplate|type={{Top_10_2010:StyleTemplate}}|usenext=2010NextLink|next=A2-Cross-Site Scripting (XSS)|useprev=2010PrevLink|prev=Main}}
 [[Category:OWASP Top Ten Project]]

@@ Line 13: / Line 13: @@
 | style="background-color: #FFB200; color: #000000;" | '''Prevalence<br>COMMON'''
 | style="background-color: #FFB200; color: #000000;" | '''Detectability<br>AVERAGE'''
-| style="background-color: #FF0000; color: #000000;" | '''Impact<br>SIMPLE'''
+| style="background-color: #FF0000; color: #000000;" | '''Impact<br>SEVERE'''
 | style="background-color: #D9D9D9; color: #000000;" | ______
 |-valign="top"

← Older revision		Revision as of 17:37, 22 April 2010
Line 58:		Line 58:
	* [http://cwe.mitre.org/data/definitions/89.html CWE Entry 89 on SQL Injection]		* [http://cwe.mitre.org/data/definitions/89.html CWE Entry 89 on SQL Injection]
	{{Top_10_2010:BottomTemplate\|usenext=2010NextLink\|next=A2-Cross-Site Scripting (XSS)\|useprev=2010PrevLink\|prev=Main}}		{{Top_10_2010:BottomTemplate\|usenext=2010NextLink\|next=A2-Cross-Site Scripting (XSS)\|useprev=2010PrevLink\|prev=Main}}
		+
		+	[[Category:OWASP Top Ten Project]]