Testing for Weak Encryption (OTG-CRYPST-004) - Revision history

Tony Hsu HsiangChih at 23:37, 9 August 2019

2019-08-09T23:37:28Z

2019-08-09T23:29:18Z

2019-08-09T23:28:26Z

‎Tools

2019-08-09T23:25:11Z

2017-07-14T02:28:38Z

‎References

2017-07-14T02:09:18Z

‎References

2017-07-06T03:04:11Z

‎Source Code Review

2017-05-12T01:55:10Z

‎References

2017-05-08T07:16:20Z

2017-05-08T07:12:39Z

@@ Line 35: / Line 35: @@
   Cipher c = Cipher.getInstance("DES/CBC/PKCS5Padding");
-* For RSA encryption, the following padding mode are suggested.
+* For the padding mode in RSA Asymmetric encryption, the uses of padding modes :
- RSA/ECB/OAEPWithSHA-1AndMGF1Padding (2048)
+PKCS#1 v2.1 (PSS, OAEP)  -- Recommended
 * Search for "ECB" or "Cipher.getInstance" , the ECB should not be used in symmetric encryption.
 The mode of operation needs to be specified since the default will be "ECB" if not specified.<syntaxhighlight lang="java">

@@ Line 42: / Line 42: @@
 The mode of operation needs to be specified since the default will be "ECB" if not specified.<syntaxhighlight lang="java">
 Cipher c = Cipher.getInstance("AES/CBC/PKCS5Padding") ;
-</syntaxhighlight>The following implementation will result in using the default "ECB" mode.<syntaxhighlight lang="java">
+</syntaxhighlight>The following implementation will result in using the default "ECB" mode, and should be avoided.<syntaxhighlight lang="java">
 Cipher c = Cipher.getInstance("AES");
 </syntaxhighlight>

@@ Line 84: / Line 84: @@
 == Tools ==
 * Vulnerability scanner such as Nessus to scan weak encryption used in protocol such as SNMP, TLS,SSH
 * Use static code analysis tool to do source code review such as klocwork, Fortify, Coverity, CheckMark for the following cases.

@@ Line 2: / Line 2: @@
 Incorrect uses of encryption algorithm may result in sensitive data exposure, key leakage, broken authentication, insecure session and spoofing attack. There are some encryption or hash algorithm is known to be weak and not suggested to be used anymore such MD5 and RC4.
-In addition to the right choices of secure encryption or hash algorithm, the right uses of parameters also mater the security level. For example, ECB (Electronic Code Book) mode is not suggested to be used in asymmetric encryption.
+In addition to the right choices of secure encryption or hash algorithm, the right uses of parameters also mater the security level. For example, ECB (Electronic Code Book) mode is not suggested to be used in symmetric encryption.
 The testing guide is trying to provide a guideline how to identify the weak encryption and hash.
@@ Line 39: / Line 39: @@
   RSA/ECB/OAEPWithSHA-256AndMGF1Padding (2048)
-* Search for "ECB", it's not allowed to be used in padding.
+* Search for "ECB" or "Cipher.getInstance" , the ECB should not be used in symmetric encryption.
+The mode of operation needs to be specified since the default will be "ECB" if not specified.<syntaxhighlight lang="java">
 * Review if different IV (initial Vector) is used.
   // Use a different IV value for every encryption

@@ Line 114: / Line 114: @@
 * http://csrc.nist.gov/groups/ST/toolkit/key_management.html
 * PBKDF2 IETF RFC 2898 and NIST SP 800-132
 = Authors and Primary Editors =
 Tony Hsu - hsiang_chih[at]yahoo.com

@@ Line 29: / Line 29: @@
   MD4, MD5, RC4, RC2, DES, Blowfish, SHA-1, ECB
-* For Java implementation, the following API is related to encyprtion. Review the parameters of the encryption implementation. For example,
+* For Java implementation, the following API is related to encyprtion. Review the parameters of the encryption implementation. The following example uses of DES is not recommended since DES is considered a weak encryption algorithm.
   SecretKeyFactory(SecretKeyFactorySpi keyFacSpi, Provider provider, String algorithm)

@@ Line 109: / Line 109: @@
 * [[Testing for SSL-TLS (OWASP-CM-001)]]
 * https://docs.oracle.com/javase/8/docs/api/javax/crypto/Cipher.html
 = Authors and Primary Editors =
 Tony Hsu - hsiang_chih[at]yahoo.com

@@ Line 54: / Line 54: @@
    Cipher cipher = Cipher.getInstance("AES/CBC/PKCS5Padding");
    cipher.init(Cipher.ENCRYPT_MODE, skey, iv);
 * In Java, search for MessageDigest to check if weak hash althorithm (MD5 or CRC) is used. For example:
@@ Line 110: / Line 109: @@
 * [[Testing for SSL-TLS (OWASP-CM-001)]]
 * https://docs.oracle.com/javase/8/docs/api/javax/crypto/Cipher.html

@@ Line 27: / Line 27: @@
 === Source Code Review ===
 * Search for the following keyword to check if any weak encryption algorithm is used.
 == Tools ==
 == References ==
@@ Line 44: / Line 109: @@
 * [[Using a broken or risky cryptographic algorithm]]
 * [[Testing for SSL-TLS (OWASP-CM-001)]]