Security Code Review Coverage - Revision history

Thomas Herlea: Switched navigation link for "Next" from an article to its navigation shell

2010-09-09T15:26:53Z

Switched navigation link for "Next" from an article to its navigation shell

Thomas Herlea: Added navigation to facilitate sequential reading online

2010-09-09T15:15:36Z

Added navigation to facilitate sequential reading online

Thomas Herlea: Typo: "one would net see" -> "one would not see"

2010-08-30T14:28:03Z

Typo: "one would net see" -> "one would not see"

KirstenS: /* Understanding the Attack Surface */

2009-02-10T23:35:52Z

‎Understanding the Attack Surface

KirstenS: /* .NET */

2009-01-23T13:16:14Z

‎.NET

KirstenS: /* Java */

2009-01-23T13:14:35Z

‎Java

KirstenS: /* Understand What You Are Reviewing */

2009-01-23T13:12:44Z

‎Understand What You Are Reviewing

KirstenS: /* Understanding the Attack Surface */

2009-01-23T13:11:57Z

‎Understanding the Attack Surface

KirstenS: /* Understand What You Are Reviewing */

2009-01-16T13:43:29Z

‎Understand What You Are Reviewing

KirstenS: /* Understanding the Attack Surface */

2009-01-16T13:42:56Z

‎Understanding the Attack Surface

@@ Line 2: / Line 2: @@
    | useprev=PrevLink | prev=Security Code Review in the SDLC | lblprev=
    | usemain=MainLink | main=OWASP Code Review Guide Table of Contents | lblmain=Table of Contents
-   | usenext=NextLink | next=Application Threat Modeling | lblnext=
+   | usenext=NextLink | next=OCRG1.1:Application Threat Modeling | lblnext=Application Threat Modeling
 }}
 __TOC__

@@ Line 1: / Line 1: @@
-[[OWASP Code Review Guide Table of Contents]]__TOC__
+{{LinkBar
+  | useprev=PrevLink | prev=Security Code Review in the SDLC | lblprev=
 ==Understanding the Attack Surface==
@@ Line 114: / Line 118: @@
 The point to make here is that many of the important security settings are not set in the code per se, but in the framework configuration files. Knowledge of the framework is of paramount importance when reviewing framework-based applications.
 [[Category:OWASP Code Review Project]]

@@ Line 75: / Line 75: @@
 '''Example''': The struts framework has a validator engine, which relies on regular expressions to validate the input data. The beauty of the validator is that no code has to be written for each form bean. (Form bean is the Java object which received the data from the HTTP request). The validator is not enabled by default in struts. To enable the validator, a plug-in must be defined in the <plug-in> section of struts-config.xml in Red above. The property defined tells the struts framework where the custom validation rules are defined (validation.xml) and a definition of the actual rules themselves (validation-rules.xml).
-Without a proper understanding of the struts framework, and by simply auditing the Java code, one would net see any validation being executed, and one does not see the relationship between the defined rules and the Java functions.
+Without a proper understanding of the struts framework, and by simply auditing the Java code, one would not see any validation being executed, and one does not see the relationship between the defined rules and the Java functions.
 The action mappings in Blue define the action taken by the application upon receiving a request. Here, above we can see that when the URL contains /login the LoginAction shall be called. From the action mappings we can see the transactions the application performs when external input is received.

@@ Line 24: / Line 24: @@
 All transactions within the application need to be identified and analyzed along with the relevant security functions they invoke. The areas that are covered during transaction analysis are:
-*Data/Input Validation of data from all untrusted sources.
+*Data/Input Validation of data from all untrusted sources
 *Authentication
 *Session Management

@@ Line 80: / Line 80: @@
 ===.NET===
-ASP.NET / IIS applications use an optional XML-based configuration file, named ''web.config'', to maintain application configuration settings.This covers issues such as authentication, authorization, Error pages, HTTP settings, debug settings, web service settings etc..
+ASP.NET / IIS applications use an optional XML-based configuration file, named ''web.config'', to maintain application configuration settings.This covers issues such as authentication, authorization, Error pages, HTTP settings, debug settings, web service settings, etc.
-Without knowledge of these files a transactional analysis would be very difficult and not accurate.
+Without knowledge of these files, a transactional analysis would be very difficult and not accurate.
 Optionally, you may provide a file ''web.config'' at the root of the virtual directory for a web application. If the file is absent, the default configuration settings in ''machine.config'' will be used. If the file is present, any settings in ''web.config'' will override the default settings.
@@ Line 106: / Line 106: @@
 '''authentication mode''': The default authentication mode is  ASP.NET forms-based authentication.
-'''loginUrl: '''Specifies the URL where the request is redirected for logon if no valid authentication cookie is found.
+'''loginUrl: '''Specifies the URL where the request is redirected for login if no valid authentication cookie is found.
 '''protection: '''Specifies that the cookie is encrypted using 3DES or DES but DV is not performed on the cookie. Beware of plaintext attacks!!

@@ Line 35: / Line 35: @@
 == Understand What You Are Reviewing ==
-Many modern applications are developed on frameworks. These frameworks provide the developer less work to do as the framework does much of the “Housekeeping”. So the objects developed by the development team shall extend the functionality of the framework. <u>It is here that the knowledge of a given framework, and language in which the framework and application is implemented, is of paramount importance. </u> Much of the transactional functionality may not be visible in the developer’s code and handled in “Parent” classes.
+Many modern applications are developed on frameworks. These frameworks provide the developer less work to do, as the framework does much of the “Housekeeping”. The objects developed by the development team shall extend the functionality of the framework. <u>It is here that the knowledge of a given framework, and language in which the framework and application is implemented, is of paramount importance. </u> Much of the transactional functionality may not be visible in the developer’s code and handled in “Parent” classes.
 The analyst must be aware and knowledgeable of the underlying framework.

@@ Line 8: / Line 8: @@
 [[Image:Transactional_Analysis.jpg]]
-A major part of actually performing a security code review is performing an analysis of the attack surface. An application takes inputs and produces output of some kind. Attacking applications is down to using the streams for input and trying to sail a battleship up them that the application is not expecting. Firstly, all input to the code needs to be identified. Input, for example, can be:
+A major part of actually performing a security code review is performing an analysis of the attack surface. An application takes inputs and produces output of some kind. Attacking applications is like using the streams for input and trying to sail a battleship up them that the application is not expecting. Firstly, all input to the code needs to be identified. Input, for example, can be:
 *Browser input
@@ Line 20: / Line 20: @@
 *Environment variables
-Exploring the attack surface includes dynamic and static data flow analysis: Where and when are variables set and how the variables are used throughout the workflow, how attributes of objects and parameters might affect other data within the program. It determines if the parameters, method calls, and data exchange mechanisms implement the required security.
+Exploring the attack surface includes dynamic and static data flow analysis: Where and when variables are set and how the variables are used throughout the workflow, how attributes of objects and parameters might affect other data within the program. It determines if the parameters, method calls, and data exchange mechanisms implement the required security.
 All transactions within the application need to be identified and analyzed along with the relevant security functions they invoke. The areas that are covered during transaction analysis are:

@@ Line 38: / Line 38: @@
 The analyst must be aware and knowledgeable of the underlying framework.
 ===Java===
 In struts the ''struts-config.xml'' and the ''web.xml'' files are the core points to view the transactional functionality of an application.
   <?xml version="1.0" encoding="ISO-8859-1" ?>